Skip to content

remove usage of the _deprecate_positional_args decorator, and tests for its behavior #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

remove usage of the _deprecate_positional_args decorator, and tests for its behavior #3225

wants to merge 7 commits into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 10, 2025

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b d-v-b added this to the 3.1.0 milestone Jul 10, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 10, 2025
@d-v-b d-v-b requested a review from dstansby July 10, 2025 17:13
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (7154f98) to head (77a9b16).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   94.76%   94.61%   -0.15%     
==========================================
  Files          78       78              
  Lines        8672     8643      -29     
==========================================
- Hits         8218     8178      -40     
- Misses        454      465      +11
Files with missing lines Coverage Δ
src/zarr/api/synchronous.py 92.85% <ø> (-1.81%) ⬇️
src/zarr/core/array.py 98.37% <ø> (-0.15%) ⬇️
src/zarr/core/group.py 94.81% <ø> (-0.07%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 11, 2025

there's a reduction in coverage, but the previously covered lines of code were not actually being tested for correctness -- they were just being run to check the behavior of the positional args decorator. So I think we can disregard the coverage reduction here.

@d-v-b
Copy link
Contributor Author

d-v-b commented Jul 11, 2025

this failure is due to recent changes to our hypothesis tests, presumably revealing a real bug, but likely one unrelated to this PR (cc @dcherian)

@d-v-b d-v-b mentioned this pull request Jul 13, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby Awaiting requested review from dstansby

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@d-v-b